Skip to content

feat(v9/nuxt): Do not inject trace meta-tags on cached HTML pages (#17305) #17319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2025

Conversation

s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented Aug 5, 2025

Backport of #17305

Don't inject tracing meta tags on cached HTML pages (SWR and pre-rendered pages). This means won't have connected traces for those pages anymore. But before, multiple pageloads were listed in one trace as they were all connected to one backend request.

Closes #16045

I spent most of the time creating the tests for this PR and verifying it works - the logic is so small 😅

Don't inject tracing meta tags on cached HTML pages (SWR and
pre-rendered pages). This means won't have connected traces for those
pages anymore. But before, multiple pageloads were listed in one trace
as they were all connected to one backend request.

Closes #16045

I spent most of the time creating the tests for this PR and verifying it
works - the logic is so small 😅


### Notes for reviewing

- the test setup is the same in nuxt-3-min and nuxt-4.
@s1gr1d s1gr1d requested review from Lms24, chargome and RulaKhaled August 5, 2025 09:28
@s1gr1d s1gr1d changed the title feat(nuxt): Do not inject trace meta-tags on cached HTML pages (#17305) feat(v9/nuxt): Do not inject trace meta-tags on cached HTML pages (#17305) Aug 5, 2025
@s1gr1d s1gr1d enabled auto-merge (squash) August 5, 2025 09:28
@s1gr1d s1gr1d merged commit 9f29e0a into v9 Aug 5, 2025
146 of 147 checks passed
@s1gr1d s1gr1d deleted the sig/v9-nuxt-cached-response branch August 5, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants